Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/620
If you want to make it specific to 'Alert' then I'm fine with that. I'm
not crazy about 'AlertsDTO', would prefer to keep the search result context in
the name, something like 'AlertsSearchResponse'. The actual name is probably
not as important though.
QueryBuilder is fine but the getESSearchQuery should return a SearchRequest
(or similarly named type). Also, you have QueryBuilder under 'model' and I
don't think that is accurate. How about moving the fields in QueryBuilder
(from, size, sort, etc) to some kind of SearchRequest model class and make
QueryBuilder responsible for building a SearchRequest? SearchRequest is a
model object that just contains fields and QueryBuilder takes care of query
(SearchRequest) generation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
