Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/817
  
    Hi @anandsubbu - Just a few issues that came to mind. These may or may not 
be problems, so I just wanted to open them for discussion.
    
    1. This will reinstall the same templates each time indexing is started.  
This may unexpectedly overwrite changes made by the user to their index 
templates.  
    
    Many of the other install actions use a file as an indicator so that it 
only performs the action once.  Maybe you could do that too?
    
    2. If Elasticsearch is not running, then the Indexing topology will fail to 
start.  While normally this is probably OK, it might not be a dependency that 
we want to introduce.  What if someone has configured their topology to not 
write to ES and is using an alternative indexing destination?
    
    What if you made it so that the topology could still start, even if 
Elasticsearch is not available?  Maybe a "best effort" to install the 
templates, but if it fails, move on.  
    
    3.


---

Reply via email to