Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/352#discussion_r87650462
  
    --- Diff: 
metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java
 ---
    @@ -246,6 +247,8 @@ private void flush(Tuple tickTuple) {
         // clear the execution state to prepare for the next window
         executor.clearState();
     
    +    profileConfig.getTickUpdate().forEach((var, expr) -> 
executor.assign(var, expr, new HashMap<>()));
    --- End diff --
    
    At this point in execution, during a flush operation, we don't have a 
telemetry message.  It is the tick tuple that drives the flush.  We won't have 
a telemetry message to offer to the 'tick' expressions.
    
    With how you have it now, the 'tick' expressions will be able to reference 
all of the state being maintained by the 'init' and 'update' expressions.
    
    The one missing piece that I can think of is that the 'tick' expressions 
cannot access the result of the 'result' expression.  It might be useful to 
offer that up to the 'tick' expressions.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to