Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/352#discussion_r87668638
--- Diff:
metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java
---
@@ -243,8 +244,18 @@ private void flush(Tuple tickTuple) {
measurement.setValue(result);
emit(measurement, tickTuple);
+ // Execute the update with the old state
+ Map<String, String> tickUpdate = profileConfig.getTickUpdate();
+ Map<String, Object> state = executor.getState();
+ if(tickUpdate != null) {
+ tickUpdate.forEach((var, expr) -> executor.assign(var, expr,
executor.getState()));
--- End diff --
The 3rd argument to executor.assign is called 'transientState'. It exists
only to make additional state available to the expression; additional state
that is not already maintained by the executor itself. The normal use for it
is when you want to make the fields in a telemetry message available to the
expression.
Setting transientState=executor.getState() does not make sense here. It is
exactly the same as passing nothing at all. The state in executor.getState()
is already exposed to the expression.
Hopefully, I am describing this well enough. As another feeble attempt at
explanation, the following two expression are equivalent.
```
tickUpdate.forEach((var, expr) -> executor.assign(var, expr,
executor.getState()));
```
```
tickUpdate.forEach((var, expr) -> executor.assign(var, expr, null));
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
