>From what I can tell, it's not up to date. For instance the doc mentions that a committer may never merge their own PR, but I know that has become somewhat standard practice recently, as long as it has been properly reviewed. In addition, the recent transient build issues have been forcing us into a place where PRs are merged against a failing master and merging a patch that remove existing tests has been discussed (METRON-597), which are explicitly forbidden by the guide. IMO we need to add some exceptions for scenarios where a failing build is properly identified as a transient issue and not something systematic.
Jon On Wed, Nov 30, 2016 at 10:00 AM Otto Fowler <[email protected]> wrote: > Are the committing guidelines up to date? When I stated committing > someone mentioned that they were not. > > > On November 29, 2016 at 16:20:59, James Sirota ([email protected]) wrote: > > We have a really old (and incomplete) coding guidelines document that I'd > like to clean up prior to our graduation. Does anyone have anything in > particular they wanted to add/change about this document? Please post > suggestions to this thread and I will incorporate them > > https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines > > ------------------- > Thank you, > > James Sirota > PPMC- Apache Metron (Incubating) > jsirota AT apache DOT org > -- Jon Sent from my mobile device
