Github user justinleet commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/402#discussion_r93672602
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/NetworkFunctions.java
---
@@ -182,8 +186,8 @@ public Object apply(List<Object> objects) {
public static class URLToPath extends BaseStellarFunction {
--- End diff --
Can you add testing around this? In particular, make sure that fragments
are handled correctly (`URI` has a separate `getFragment()`, so I assume that
they are not returned by `getPath()`. I could be wrong about this, though, I
haven't run a test on it.). If this is the case, we may also want/need a
`TO_FRAGMENT` function that handles this appropriately, although I'm fine with
that being a separate conversation/jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
