Github user justinleet commented on the issue:
https://github.com/apache/incubator-metron/pull/402
I am concerned about the naming and documentation of the functions, given
that URIs are used under the hood for everything. URIs are a super set of URLs,
so now we have a set of URL specific functions that accept a superset of the
documented and named input.
e.g. URL_TO_PROTOCOL doesn't actually limit itself to URLs. It happily
accepts a (non-URL) URI, and returns an answer, even though by the name and
documentation of the function I would really expect at least a warning, and
more likely an error. "urn:isbn:0451450523" isn't even a URL, but
URL_TO_PROTOCOL informs me that its scheme is "urn". This particular example
obviously doesn't really apply to what we're doing, but one could imagine
others do.
Even if we choose to keep the naming as-is, I want to see tests on URIs
that aren't URLs, to ensure that they behave rationally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
