On 10/25/07, Trustin Lee <[EMAIL PROTECTED]> wrote: > > On 10/25/07, Maarten Bosteels <[EMAIL PROTECTED]> wrote: > > On 10/25/07, Trustin Lee <[EMAIL PROTECTED]> wrote: > > > > > > On 10/24/07, Maarten Bosteels <[EMAIL PROTECTED]> wrote: > > > > On 10/23/07, Trustin Lee <[EMAIL PROTECTED]> wrote: > > > > > > > > > > On 10/23/07, Maarten Bosteels <[EMAIL PROTECTED]> wrote: > > > > > > Hi, > > > > > > > > > > > > Some comments: > > > > > > > > > > > > 1) I understand your worries about performance impact but I > think we > > > > > should > > > > > > to a little benchmark before jumping to conclusions. Maybe you > > > already > > > > > did > > > > > > ? > > > > > > > > > > Good idea. I didn't do any benchmark yet. But my primary concern > is > > > > > not performance now. It's impedance mismatch. I feel like we are > > > > > working around the problem. We can go as we discussed so far, but > > > > > it's also a lot of fun to explore another possibility. Please > don't > > > > > get me wrong. :) > > > > > > > > > > > 2) I was planning to create an Enum of all the keys that > > > > > MdcInjectionFilter > > > > > > supports (remoteAddress, remotePort,...) > > > > > > and add a constructor that takes an EnumSet, that way users can > > > minimize > > > > > the > > > > > > size of the map. > > > > > > > > > > That would be really nice. > > > > > > > > Done, please review. > > > > > > Great job! I've done some additional tweak: > > > > > > http://svn.apache.org/viewvc?view=rev&revision=588153 > > > > > > Please review. ;) > > > > > > Yes, much better, thanks (and I should have cleaned up that unused code > > myself) > > > > I am not sure getProperty should fall back to values in the MDC though. > > I am not sure actually. :) > > Would there be any side effect?
Well, I can't really think of a reason to call getProperty (that's why I didn' add it :-) but I think the values in the MDC and the values in the Context are two different sets: when a key/value is in the MDC but not in the context of the mdcFilter it will not be added to the MDC for the next event. users can directly access the MDC, so why is the fallback needed ? Maarten Trustin > -- > what we call human nature is actually human habit > -- > http://gleamynode.net/ > -- > PGP Key ID: 0x0255ECA6 >
