On 10/25/07, Maarten Bosteels <[EMAIL PROTECTED]> wrote: > > > I am not sure getProperty should fall back to values in the MDC though. > > > > I am not sure actually. :) > > > > Would there be any side effect? > > > Well, I can't really think of a reason to call getProperty (that's why I > didn' add it :-) > > but I think the values in the MDC and the values in the Context are two > different sets: > when a key/value is in the MDC but not in the context of the mdcFilter it > will not be added to the MDC for the next event. > > users can directly access the MDC, so why is the fallback needed ?
Just wanted to make the API look complete. I just couldn't imagine setter without getter. :) BTW, I rewrote the IoSessionLogger as we discussed. Please review the following classes: http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/common/IoSessionLogger.java?view=markup http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/logging/LoggingFilter.java?view=markup I hope it is just exactly what you imagined. :D Cheers, Trustin -- what we call human nature is actually human habit -- http://gleamynode.net/ -- PGP Key ID: 0x0255ECA6
