This certainly does seem cleaner. One problem I found is that your changes broke KeepAliveFilterTest.
A pet peave of mine is that exceptions should be more clear. So for instance, in the constructors we should say something more than "messageFactory" or "policy". We should say that they are null and they shouldn't be. Another argument for this change is consistency. In KeepAliveFilter.setKeepAliveRequestInterval(), we state in the exception that 'keepAliveRequestInterval' must be a positive integer but in the constructors we just provide the parameter name. just my 2 cents. Mark On Nov 13, 2007 11:06 PM, Trustin Lee <[EMAIL PROTECTED]> wrote: > Hi all, > > As Eero pointed out, the original KeepAliveFilter contribution had > somewhat limited use cases. I wrote a new KeepAliveFilter based on > his work to make it work with more use cases. I think JavaDoc is > pretty complete so please browse the source: > > http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/keepalive/KeepAliveFilter.java?view=markup > > There are two major differences from the original implementation: > * it uses sessionIdle event to detect idle sessions. > * it is now a real filter. (it was not a filter originally) > > Any feed back is appreciated. > > Cheers, > Trustin > -- > what we call human nature is actually human habit > -- > http://gleamynode.net/ > -- > PGP Key ID: 0x0255ECA6 > -- -------------------------------- The adjuration to be "normal" seems shockingly repellent to me; I see neither hope nor comfort in sinking to that low level. I think it is ignorance that makes people think of abnormality only with horror and allows them to remain undismayed at the proximity of "normal" to average and mediocre. For surely anyone who achieves anything is, essentially, abnormal. Dr. Karl Menninger
