On Nov 14, 2007 1:21 PM, Mark <[EMAIL PROTECTED]> wrote: > This certainly does seem cleaner. One problem I found is that your > changes broke KeepAliveFilterTest.
Oops! Fixed(?) now. > A pet peave of mine is that exceptions should be more clear. So for > instance, in the constructors we should say something more than > "messageFactory" or "policy". We should say that they are null and > they shouldn't be. Another argument for this change is consistency. > In KeepAliveFilter.setKeepAliveRequestInterval(), we state in the > exception that 'keepAliveRequestInterval' must be a positive integer > but in the constructors we just provide the parameter name. Yep, more documentation is needed, which should be revised on and on. Thanks! Trustin -- what we call human nature is actually human habit -- http://gleamynode.net/ -- PGP Key ID: 0x0255ECA6
