Great! I'm also writing JavaDocs when I see some big hole. Go MINA! :) Trustin
On Nov 14, 2007 8:57 PM, Mark <[EMAIL PROTECTED]> wrote: > I can start to go through the code and update the exception messages. > I have been really busy with work lately but should have some time to > start looking at this. > > > On Nov 13, 2007 11:52 PM, Trustin Lee <[EMAIL PROTECTED]> wrote: > > On Nov 14, 2007 1:21 PM, Mark <[EMAIL PROTECTED]> wrote: > > > This certainly does seem cleaner. One problem I found is that your > > > changes broke KeepAliveFilterTest. > > > > Oops! Fixed(?) now. > > > > > A pet peave of mine is that exceptions should be more clear. So for > > > instance, in the constructors we should say something more than > > > "messageFactory" or "policy". We should say that they are null and > > > they shouldn't be. Another argument for this change is consistency. > > > In KeepAliveFilter.setKeepAliveRequestInterval(), we state in the > > > exception that 'keepAliveRequestInterval' must be a positive integer > > > but in the constructors we just provide the parameter name. > > > > Yep, more documentation is needed, which should be revised on and on. > > > > Thanks! > > > > Trustin > > -- > > what we call human nature is actually human habit > > -- > > http://gleamynode.net/ > > -- > > PGP Key ID: 0x0255ECA6 > > > > > > > -- > -------------------------------- > The adjuration to be "normal" seems shockingly repellent to me; I see > neither hope nor comfort in sinking to that low level. I think it is > ignorance that makes people think of abnormality only with horror and > allows them to remain undismayed at the proximity of "normal" to > average and mediocre. For surely anyone who achieves anything is, > essentially, abnormal. > Dr. Karl Menninger > -- what we call human nature is actually human habit -- http://gleamynode.net/ -- PGP Key ID: 0x0255ECA6
