Okay, I just checked in all my changes to the trunk for review/test/further enhancements. Below are a few questions:
1. Do we want to always send a specific type of reply from a specific command? In other words, do we want a command (e.g. RETR) to send a generic FtpReply in some cases and DataTransferFtpReply in some cases? There is currently once place in the data transfer commands (STOR, RETR etc) where I'm sending a DefaultFtpReply. Perhaps we should change it to send DataTransferFtpReply? 2. What additional information can possibly be added to the new FtpReply interfaces? 3. Do we want to add a new method to the FtpFile interface that returns the physical path of the file as a String? I recommend that we do this, but would like to know what you guys think. Regards, Sai Pullabhotla Phone: (402) 408-5753 Fax: (402) 408-6861 www.jMethods.com On Mon, Apr 13, 2009 at 1:33 PM, Niklas Gustavsson <[email protected]>wrote: > On Mon, Apr 13, 2009 at 2:19 PM, Sai Pullabhotla > <[email protected]> wrote: > > I worked over the weekend to add another type of reply for commands like > > MKD, RMD, DELE etc and updated these commands. I think I should be able > to > > check these in for review/any tweaking. Can one of you tell me if I > should > > commit all changes together or file by file with commit comments specific > to > > each file? > > Do all at a time. > > /niklas >
