On Mon, Apr 13, 2009 at 9:41 PM, Sai Pullabhotla <[email protected]> wrote: > Sorry, I do not have JUnit setup yet to run the test cases. But I hope the > errors you have seen are related to the ListFormatter test cases where the > new method added to the FtpFile was not implemented. I added that method to > the test classes and checked those in. I simply returned a string "/short" > from the getPhysicalFile method in these classes. I was not sure what else > to return. Hope that takes care of it.
Yes, seems like the tests are going back to green. Doesn't running "mvn test" run the tests for you? > Regarding the addition of getPhysicalFileAsString method to the FtpFile, I > think we should enforce the implementation classes to do it so generic > Ftplets such as a logging Ftplet can be sure of getting a valid value > instead of getting a pointer back in case an Ftplet returns a physical file > with no toString() implemented. How about adding a statement to getPhysicalFile() that states that toString() on whatever it returns should a reasonable value? I don't feel to easy about us enforcing another way of getting the string representation. toString() seems fairly established :-) /niklas
