On Mon, Apr 13, 2009 at 8:38 PM, Sai Pullabhotla <[email protected]> wrote: > Okay, I just checked in all my changes to the trunk for review/test/further > enhancements.
Seems like the test broke, can you have a look at it? > Below are a few questions: > 1. Do we want to always send a specific type of reply from a specific > command? In other words, do we want a command (e.g. RETR) to send a generic > FtpReply in some cases and DataTransferFtpReply in some cases? There is > currently once place in the data transfer commands (STOR, RETR etc) where > I'm sending a DefaultFtpReply. Perhaps we should change it to send > DataTransferFtpReply? I don't care particulary if a command return different types of replies. The user of the replies should always check the type before using. > 3. Do we want to add a new method to the FtpFile interface that returns the > physical path of the file as a String? I recommend that we do this, but > would like to know what you guys think. The use case for this would be for auditing purposes as you described earlier? I would say that getPhysicalFile().toString() should suffice. /niklas
