[
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847103#action_12847103
]
Sai Pullabhotla commented on FTPSERVER-357:
-------------------------------------------
I think I can get it to work with the old methods and constructors in
the factory classes. Just wanted to get it going so, the quickest way
was to remove/change signatures. I will look into it some more and let
you know.
I will double check the AbstractListener and see if I formatted the
whole class. If I did, I will re-apply may changes to the version from
trunk.
Yeah, the FileSystem class changes were an accidental inclusion in the
patch. I might open a new thread on this as I think it would be nice
to have some of these member variables accessible in subclasses. It
was a while ago I was playing with a subclass and needed those. I'll
have to rewind and figure out what I was doing then.
I don't think the DefaultIpFilter needs to be immutable. The class is
extended from a Set that makes a copy of the Set on every change to
the Set, so it is safe to modify the Set while an iterator is
iterating over the items. Of course, I stole the idea from the
existing filter in MINA.
If everything else looks okay, and if you think the package/class
names are good as they are, I will go ahead and try to wrap this up
this week.
> Implement IP Filtering based on black or white list
> ---------------------------------------------------
>
> Key: FTPSERVER-357
> URL: https://issues.apache.org/jira/browse/FTPSERVER-357
> Project: FtpServer
> Issue Type: New Feature
> Components: Core
> Reporter: Sai Pullabhotla
> Fix For: 1.1.0
>
> Attachments: ftpserver-ipfilter.patch
>
>
> Create a new IP Filter based on black or white list to deny or allow incoming
> client connections.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
