[ 
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847377#action_12847377
 ] 

Sai Pullabhotla commented on FTPSERVER-357:
-------------------------------------------

Well, I thought about that possibility. We can do it if we enforce the filter 
type in the IpFilter interface. Right now, the IpFilter has just  one method, 
accept(). We could add getType() method which would return a type too. But I 
hate to enforce this at the interface level, which may not make sense when 
implementing custom filters where they do not care about the type or the type 
of the filter does not fall into the categories we support (DENY/ALLOW). The 
best we could do is, check to see if IpFilter is an instance of 
DefaultIpFilter, if so, check if it is of type DENY, and then return the list. 
Return null/blank list in all other cases. Hope it makes sense. Let me know 
what you think of this approach or any other ideas you may have. 

> Implement IP Filtering based on black or white list
> ---------------------------------------------------
>
>                 Key: FTPSERVER-357
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-357
>             Project: FtpServer
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Sai Pullabhotla
>             Fix For: 1.1.0
>
>         Attachments: ftpserver-ipfilter.patch
>
>
> Create a new IP Filter based on black or white list to deny or allow incoming 
> client connections. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to