[ 
https://issues.apache.org/jira/browse/FTPSERVER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847365#action_12847365
 ] 

Sai Pullabhotla commented on FTPSERVER-357:
-------------------------------------------

Okay guys, I think I updated the ListenerFactory to have the old methods and 
marked them as deprecated. If the blockedAddresses or blockedSubnets are 
specified on the factory, they cannot set ipFilter. In other words, ipFilter 
and blocked* are mutually exclusive. If both are set, calling the 
createListener would raise an exception. This is similar to what I did with the 
spring configuration. Let me know if this is okay with you. 

Also, the Listener interface has getBlocked* methods. Do we want to make these 
available too? I don't think this is possible, especially when there is a 
custom filter. At the same time, I doubt if anybody is working directly with 
listeners. Let me know what you think. 

> Implement IP Filtering based on black or white list
> ---------------------------------------------------
>
>                 Key: FTPSERVER-357
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-357
>             Project: FtpServer
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Sai Pullabhotla
>             Fix For: 1.1.0
>
>         Attachments: ftpserver-ipfilter.patch
>
>
> Create a new IP Filter based on black or white list to deny or allow incoming 
> client connections. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to