[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675514#comment-16675514
]
Goldstein Lyor commented on SSHD-849:
-------------------------------------
Hi Roberto,
I appreciate the effort, but I cannot review the link you sent as it is (still)
* out-of-date with master
* contains re-formatting
* contains code that does not seem part of the patch
I propose you try the following procedure:
1. fork on github https://github.com/apache/mina-sshd/ to your account
2. {{git clone https://github.com/apache/mina-sshd.git}}
3. {{git remote add fork https://github.com/YOURUSER/mina-sshd.git}}
4. {{git checkout origin/master -b SSHD-849}}
5. Make your changes (reminder: do not re-format the files)
6. {{git commit -m ".....commit message(s)..."}}
7. {{git push -u fork SSHD-849}} -- need to do it only the *first* time you
push Afterwards you can simply {{git push}}
8. Keep committing and pushing changes
Once you think the code is ready for review
* Go to *your* github fork of the code
* Select the SSHD-849 branch - you will see a large green button called
{{Compare & Pull request}}
* Click it
* Go over the PR and make sure it contains *only your changes* and nothing
else
* Submit it
Until we have a "clean" PR I cannot review the code with any degree of
certainty...
> Possible race condition for local port forwarding channels
> ----------------------------------------------------------
>
> Key: SSHD-849
> URL: https://issues.apache.org/jira/browse/SSHD-849
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.1.1
> Reporter: Roberto Deandrea
> Assignee: Goldstein Lyor
> Priority: Major
> Fix For: 2.1.1
>
>
> Hi Lyor,
> We found another critical race condition sending data through local port
> forwarding channels that causes loosing data bytes sent by client to target
> server.
> As soon as possible I will open a pull request with our potential changes to
> fix this issue.
> I let you know when done because I would like to know your feedback.
> Hi Lyor,
> We made some code changes to your proposed solution based on
> ClientChannelPendingMessageQueue.
> You can find our commit at
> https://github.com/robertodeandrea/mina-sshd/commit/4523138ee2b4efa483bc956e8769eafb13eff05d
> Can you review our code and give us feedback ?
> If it satisfies you can you merge it in Apache SSHD master repository ?
> Our definitive working code is at
> https://github.com/robertodeandrea/mina-sshd/commit/c381e522dc254387009d82612dc15f0c584dece6
> Cheers.
> Roberto
> Cheers
> Roberto
> The code changes against master code are :
> https://github.com/robertodeandrea/myclone/commit/0602840140ce82f51446b0d5a05fb409e730adad
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
