[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676595#comment-16676595
]
Goldstein Lyor commented on SSHD-849:
-------------------------------------
Here is how to make sure you are correctly rebased (assuming you have followed
my previous instructions)
* Edit your {{~/.gitconfig}} file and add
{noformat}
[pull]
rebase = true
{noformat}
** or {code:bash}git config --global pull.rebase true{code}
** or {code:bash}git config pull.rebase true{code} - if you don't want it in
all your projects
* {{git co master}} - assuming {{origin/master}} is the MINA SSHD github project
* {{git pull -tp}}
* {{git co master -b SSHD-849}}
* ...make only your changes...
* {{git push -u (if 1st time yous push this branch) -f (if you already have
pushed this branch) fork SSHD-849}}
* Go to your github fork and create a PR
I would like to emphasize again - please do not reformat the code and make sure
only your changes are in the commit.
> Possible race condition for local port forwarding channels
> ----------------------------------------------------------
>
> Key: SSHD-849
> URL: https://issues.apache.org/jira/browse/SSHD-849
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.1.1
> Reporter: Roberto Deandrea
> Assignee: Goldstein Lyor
> Priority: Major
> Fix For: 2.1.1
>
>
> Hi Lyor,
> We found another critical race condition sending data through local port
> forwarding channels that causes loosing data bytes sent by client to target
> server.
> As soon as possible I will open a pull request with our potential changes to
> fix this issue.
> I let you know when done because I would like to know your feedback.
> Hi Lyor,
> We made some code changes to your proposed solution based on
> ClientChannelPendingMessageQueue.
> You can find our commit at
> https://github.com/robertodeandrea/mina-sshd/commit/4523138ee2b4efa483bc956e8769eafb13eff05d
> Can you review our code and give us feedback ?
> If it satisfies you can you merge it in Apache SSHD master repository ?
> Our definitive working code is at
> https://github.com/robertodeandrea/mina-sshd/commit/c381e522dc254387009d82612dc15f0c584dece6
> Cheers.
> Roberto
> Cheers
> Roberto
> The code changes against master code are :
> https://github.com/robertodeandrea/myclone/commit/0602840140ce82f51446b0d5a05fb409e730adad
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
