[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676315#comment-16676315
]
ASF GitHub Bot commented on SSHD-849:
-------------------------------------
GitHub user robertodeandrea opened a pull request:
https://github.com/apache/mina-sshd/pull/80
SSHD-849 working code for pull request
Lyor, this is my pull request according to your instructions for review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertodeandrea/mina-sshd SSHD-849
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mina-sshd/pull/80.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #80
----
commit c9cf7ce16367926da56f1444e8479dee63de7241
Author: roberto.deandrea <roberto.deandrea@...>
Date: 2018-11-06T07:58:36Z
SSHD-849 working code for pull request
----
> Possible race condition for local port forwarding channels
> ----------------------------------------------------------
>
> Key: SSHD-849
> URL: https://issues.apache.org/jira/browse/SSHD-849
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.1.1
> Reporter: Roberto Deandrea
> Assignee: Goldstein Lyor
> Priority: Major
> Fix For: 2.1.1
>
>
> Hi Lyor,
> We found another critical race condition sending data through local port
> forwarding channels that causes loosing data bytes sent by client to target
> server.
> As soon as possible I will open a pull request with our potential changes to
> fix this issue.
> I let you know when done because I would like to know your feedback.
> Hi Lyor,
> We made some code changes to your proposed solution based on
> ClientChannelPendingMessageQueue.
> You can find our commit at
> https://github.com/robertodeandrea/mina-sshd/commit/4523138ee2b4efa483bc956e8769eafb13eff05d
> Can you review our code and give us feedback ?
> If it satisfies you can you merge it in Apache SSHD master repository ?
> Our definitive working code is at
> https://github.com/robertodeandrea/mina-sshd/commit/c381e522dc254387009d82612dc15f0c584dece6
> Cheers.
> Roberto
> Cheers
> Roberto
> The code changes against master code are :
> https://github.com/robertodeandrea/myclone/commit/0602840140ce82f51446b0d5a05fb409e730adad
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
