alex-sherwin commented on a change in pull request #194:
URL: https://github.com/apache/mina-sshd/pull/194#discussion_r632209342
##########
File path: sshd-core/pom.xml
##########
@@ -105,8 +105,25 @@
<artifactId>ganymed-ssh2</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>testcontainers</artifactId>
+ <scope>test</scope>
+ </dependency>
</dependencies>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>testcontainers-bom</artifactId>
+ <type>pom</type>
+ <version>${testcontainers.version}</version>
+ <scope>import</scope>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
+
Review comment:
Fixed this by pinning jna to 5.8.0
I also needed to change the sshd-mina pom to exclude re-running
ClientOpenSSHCertificatesTest, it seems to fail reading the contents of files
from the classpath brought in by the reusable test jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
