tomaswolf commented on pull request #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841215391
No, not really. A profile was just the first thing that I thought of. An unsuspecting user who doesn't have docker on his machine should probably still be able to run a maven build locally and just have the tests that require testcontainers be skipped/not run. OTOH, we'd want to enable that profile in the build Github action for the Linux builds. But maybe there are better ways to do this than via profiles. I also thought the Github Windows VMs did have docker: - https://github.com/actions/virtual-environments/blob/main/images/win/Windows2016-Readme.md - https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md Maybe it's a testcontainers problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
