tomaswolf commented on pull request #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841716792
This looks great. Thanks a lot! The PR now contains a lot of commits that leave intermediary stages in the repo and a lot of clean-up commits, and merging in master in the middle will make for a strange commit history when merged. I prefer to ultimately merge commits such that master builds at any stage, so I'd like to refactor this series of commits before merging: * Rebase it onto master, then: * One commit for the completely unrelated formatting clean-up in ReflectionUtils * One commit by Alec for the renaming of OpenSshCertificate.getServerHostKey() * One commit by you with Alec mentioned in the commit message for all the main code changes * One commit by you for the test and the testcontainers setup @alex-sherwin , would it be OK with you if I did such a refactoring of the commits? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
