FliegenKLATSCH commented on pull request #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841791524
Nice work, two comments from my side: - If we have the `SIGNATURE_ALGORITHM_MAP` now, we should remove the [mapping](https://github.com/apache/mina-sshd/pull/164/commits/374748385a117d0a2e0ca4710d30fe60c2b4d976) I introduced in the RSA classes, it's just duplicated.. - We should still somewhere validate the type of the certificate such that a host certificate cannot be used for user authentication and vice versa. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
