tomaswolf commented on PR #217: URL: https://github.com/apache/mina-sshd/pull/217#issuecomment-1100609787
I know it's non-trivial. That's why there are so many inline comments, and a lengthy commit message. I've tested it as good as I can. But so far I've failed to write a test that would reproduce either the original lock inversion or the race (when run without this change). I went through a number of false starts when developing this, which I discovered when tests failed. Luckily we do have a fairly comprehensive test suite, and it does some fairly unusual things in a number of places, too. If our test suite succeeds I'm fairly confident that a change is correct. The overall state machine of KEX is not that complicated. In our code it's a bit hard to follow because it's intermingled with other code. I'll see if I can come up with some diagram that might help to understand this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
