lgoldstein commented on PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#issuecomment-1101422734

   > Looks like I really need to get rid of the synchronized methods in 
ChannelOutputStream and ChannelAsyncOutputStream.
   
   This should be done **carefully** - I believe the synchronization is in 
place for good reason. BTW, I dimly remember that I encountered the same issue 
and when I tried to get rid of the synchronization (or at least limit its 
scope) I got into trouble. Keeping my fingers crossed you can come up with 
something...
   
   BTW, at some point it may be worth re-evaluating the price in effort and 
code complexity vs the benefits - this is what got me to abort the attempt 
originally - the code was becoming way too convoluted and the effort of 
maintaining in future releases seemed to me to be too prohibitive.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to