tomaswolf commented on PR #217: URL: https://github.com/apache/mina-sshd/pull/217#issuecomment-1103647246
> This should be done carefully Of course. I'm not being reckless. As for complexity: yes, the current code is convoluted and complex, and uses too many locks with too broad scopes. Reducing synchronization on locks with broad scope, or possibly even eliminating some of these altogether simplifies the overall structure of the code and will make it easier to understand, even if it may _locally_ increase perceived complexity. Factoring out certain things into dedicated classes/objects may actually help reducing complexity or at least keeping it local to isolated classes and making the code easier to understand overall. The current implementation has bugs that cause deadlocks in production servers. I know we don't provide any guarantees that our open-source software actually works or was fit for any purpose, but personally I don't like maintaining software that I know has such bugs. As long as it's fun trying to solve such problems and as long as I do have the time, I'm happy to try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
