vukzeka commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870067540
##########
sshd-core/src/test/java/org/apache/sshd/certificates/GenerateOpenSSHClientCertificateTest.java:
##########
@@ -154,7 +150,12 @@ public void signCertificate() throws Exception {
.publicKey(clientPublicKey)
.id("user01")
.principals(Collections.singletonList("user01"))
+ .criticalOptions(Arrays.asList(
+ new
OpenSshCertificate.CertificateOption("force-command", "/path/to/script.sh"),
+ new
OpenSshCertificate.CertificateOption("source-address", "127.0.0.1/32"),
+ new
OpenSshCertificate.CertificateOption("verify-required")))
.extensions(Arrays.asList(
+ new
OpenSshCertificate.CertificateOption("no-touch-required"),
Review Comment:
hi @tomaswolf
Based on specs I believe no-touch-required should be used only with sk keys.
I added it here for completeness of all available critical
options/extensions as in the code **CertificateOptions** are not constants so
we do not have enumeration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
