vukzeka commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870069420
##########
sshd-core/src/test/java/org/apache/sshd/certificates/GenerateOpenSSHClientCertificateTest.java:
##########
@@ -154,7 +150,12 @@ public void signCertificate() throws Exception {
.publicKey(clientPublicKey)
.id("user01")
.principals(Collections.singletonList("user01"))
+ .criticalOptions(Arrays.asList(
+ new
OpenSshCertificate.CertificateOption("force-command", "/path/to/script.sh"),
+ new
OpenSshCertificate.CertificateOption("source-address", "127.0.0.1/32"),
+ new
OpenSshCertificate.CertificateOption("verify-required")))
Review Comment:
@tomaswolf i didn't add there as would be required to change all existing
certs as message is now different meaning signature and message check will not
pass.
Probably better would be to add separate test for these. I will see later
what would be best and will update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
