vukzeka commented on PR #222: URL: https://github.com/apache/mina-sshd/pull/222#issuecomment-1124693963
> Looks good, some minor comments. > > I notice that the tests add the options already in the correct order. Now that we do sort I'd suggest to change the tests to add them in a wrong order. > > If you want to do a testcontainers test, I suggest to do a new PR once this one is merged. Hope is ok now. Yes, I will add also one test for ssh-keygen later this week and that will be separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
