vukzeka commented on code in PR #222:
URL: https://github.com/apache/mina-sshd/pull/222#discussion_r870828179


##########
sshd-core/src/test/java/org/apache/sshd/certificates/GenerateOpenSSHClientCertificateTest.java:
##########
@@ -154,7 +150,12 @@ public void signCertificate() throws Exception {
                 .publicKey(clientPublicKey)
                 .id("user01")
                 .principals(Collections.singletonList("user01"))
+                .criticalOptions(Arrays.asList(
+                        new 
OpenSshCertificate.CertificateOption("force-command", "/path/to/script.sh"),
+                        new 
OpenSshCertificate.CertificateOption("source-address", "127.0.0.1/32"),
+                        new 
OpenSshCertificate.CertificateOption("verify-required")))

Review Comment:
   ok, just regenerated certs but i have separated them from the old ones as 
there is other test which is using same and it fails with dummy critical 
options (source-address, force-command). There is sh script which can be used 
to easily generate/regenerate if needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to