tomaswolf commented on issue #884: URL: https://github.com/apache/mina-sshd/issues/884#issuecomment-4000579321
1. Line 110: as the comment above that line explains this actually prevents sending window adjustments for very small amounts. 2. Line 114: this is the same logic [as in OpenSSH](https://github.com/openssh/openssh-portable/blob/2a387ba37452971747d2f00db7d4c18b4f2c45ed/channels.c#L2435). Changing this would require very good reasons and intensive tests with different window and packet sizes. 3. AtomicLong: indeed that looks redundant but is highly unlikely to be a performance bottleneck. 4. Synchronization: is highly unlikely to be a performance bottleneck. This channel window logic was introduced in commit 78ed6bc9 in 2022, two years before version 2.13.0 or 2.13.2. So this logic cannot possibly be responsible for any alleged performance drop in SFTP transfers that you might observe between versions 2.13.2 and 2.15.0. There must be some other reason. Note that we have the sshd-benchmark project which can be used to benchmark SFTP uploads. That project was added in 2.14.0 and was used extensively to check SFTP uploads for performance problems. Last I remember SFTP upload speed of Apache MINA SSHD was about on par with JSch or OpenSSH. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
