tomaswolf commented on issue #884: URL: https://github.com/apache/mina-sshd/issues/884#issuecomment-4004147327
To answer your questions: yes, there have been many changes in 2.14.0 related to SFTP file transfers. You'd have to go through the commit history to find the commits dealing with SFTP performance issues. However, all these changes were extensively tested performance _improvements_, carefully monitored using the sshd-benchmarks project. I don't remember changes since 2.13.x that would explicitly change the places where release() is called, though. Admittedly timing such SFTP transfers is tricky, and the benchmark numbers are to be taken with a (huge) grain of salt. Running a server locally in a docker container may skew results as the local CPUs will be also busy running the server. Using an external server in AWS (which I also did) may add uncontrollable variable network latency. Plus in either case I found that having other background tasks (virus scanners, e-mail programs checking for e-mail, browsers, even just moving the mouse pointer) during these performance tests would skew results. Maybe instrumenting the code in LocalWindow.release() to log each call with the actual len value may give additional insights. Perhaps there is something that causes many many calls with very small `len`, or perhaps even with `len == 0` (which would be a bug). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
