tomaswolf commented on issue #884: URL: https://github.com/apache/mina-sshd/issues/884#issuecomment-4010137175
Changing that window logic is not the right approach. The logic is the unchanged since 2.13.0, so whatever causes the performance drop you see must be something else. Looks like the window logic works as it's supposed to do. But I don't understand why we see so many "consumed" logs of 16kB when you're sending 64kB. Somehow it looks as if the client sends 16kB chunks of data? Can you provide a simple maven project with a simple client and a simple SFTP server, the client doing file uploads, which would show this performance drop between 2.13.2 and 2.15.0? Without a reproducer that I could analyze myself locally tracking this down will be very difficult. Another approach might be to start bisecting to find out whether there is any particular commit at which the performance drops. Also, the latest Apache SSHD version is 2.17.1. Do you still see that same performance drop between 2.13.2 and 2.17.1? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
