> A snapshot has also been deployed.
> Very good if people can testdrive them an give feedback.
> 

David, 

I did notice that there have been some minor checksytle errors introduced
since the 2.2 release.

I've attached a patch that fixes these errors.  Feel free to modify the
patch. 

Thanks,


-Nate

Index: src/main/java/org/codehaus/mojo/taglist/beans/FileReport.java
===================================================================
--- src/main/java/org/codehaus/mojo/taglist/beans/FileReport.java	(revision 8412)
+++ src/main/java/org/codehaus/mojo/taglist/beans/FileReport.java	(working copy)
@@ -71,6 +71,7 @@
      * Constructor.
      *
      * @param file The file to analyze.
+     * @param encoding the file encoding to use for the report.
      */
     public FileReport( File file, String encoding )
     {
@@ -101,9 +102,16 @@
         return className.replace( '.', '/' );
     }
 
-    private Reader getReader( File file ) throws IOException
+    /**
+     * Access an input reader that uses the current file encoding.
+     *
+     * @param fileToRead the file to open in the reader.
+     * @throws IOException the IO exception.
+     * @return a reader with the current file encoding.
+     */
+    private Reader getReader( File fileToRead ) throws IOException
     {
-        InputStream in = new FileInputStream( file );
+        InputStream in = new FileInputStream( fileToRead );
         return ( encoding == null ) ? new InputStreamReader( in ) : new InputStreamReader( in, encoding );
     }
 
Index: src/main/java/org/codehaus/mojo/taglist/FileAnalyser.java
===================================================================
--- src/main/java/org/codehaus/mojo/taglist/FileAnalyser.java	(revision 8412)
+++ src/main/java/org/codehaus/mojo/taglist/FileAnalyser.java	(working copy)
@@ -169,6 +169,13 @@
         return filesList;
     }
 
+    /**
+     * Access an input reader that uses the current file encoding.
+     *
+     * @param file the file to open in the reader.
+     * @throws IOException the IO exception.
+     * @return a reader with the current file encoding.
+     */
     private Reader getReader( File file ) throws IOException
     {
         InputStream in = new FileInputStream( file );
---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

Reply via email to