[ 
http://jira.codehaus.org/browse/MOJO-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=221091#action_221091
 ] 

Mark Struberg commented on MOJO-1529:
-------------------------------------

Hi Peter!

Looks good so far. But can be improved even more  ;)
Maybe it would be wise to skip the execution of the plugin for poms with type 
'pom' (parent-poms with no actual code)?
You can look at the sources of the openjpa-maven-plugin or sql-maven-plugin. 
This is in sync with lots of other plugins which already exist in the maven 
space. The reason for this is that you maybe like to enforce those rules for 
your whole project, thus enabling the plugin configuration in your projects 
parent pom - but don't have any code to enforce the rules upon in the parent 
pom project itself. There is a 2nd property 'forceMojoExecution' just in case 
if you really like to execute those rules for you parent pom too.

> Add more configuration options to Maven 2 Macker Plugin
> -------------------------------------------------------
>
>                 Key: MOJO-1529
>                 URL: http://jira.codehaus.org/browse/MOJO-1529
>             Project: Mojo
>          Issue Type: New Feature
>          Components: macker
>            Reporter: Peter Kofler
>         Attachments: ExtendedConfAndTestCases-rev61.diff
>
>
> Add more configuration options to Maven 2 Macker Plugin, like 
> * skip, 
> * work on test classes as well
> * allow multiple ruleset files, 
> * find rules in classpath
> * includes, excludes of files
> (in fact everything PMD Maven Plugin can do)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to