[
http://jira.codehaus.org/browse/MNBMODULE-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=241531#action_241531
]
Jesse Glick commented on MNBMODULE-112:
---------------------------------------
There is a lot of stuff in the patch that does not obviously belong here.
Please go over patches very carefully before submission to check that every
line contributes to fixing the stated bug. In this case, the changes to pom.xml
should be discarded, master.jnlp has been completely reformatted for no
apparent reason, and most of the patch in CreateWebstartAppMojo.java is
needless reformatting; it is hard to see what in fact you are changing.
> Pass <additionalParameters> and <target>1.6</target> for jnlp creation
> -----------------------------------------------------------------------
>
> Key: MNBMODULE-112
> URL: http://jira.codehaus.org/browse/MNBMODULE-112
> Project: Maven NetBeans Module Plugin
> Issue Type: Improvement
> Reporter: Gabriele Kahlout
> Assignee: Jesse Glick
> Attachments: vmargs.diff
>
>
> These are there
> in the additionalArguments, but the MaveProject project reference didn't
> have it in the createwebstart phase (though it's there in the pom.xml).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
