[ 
http://jira.codehaus.org/browse/MNBMODULE-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=241533#action_241533
 ] 

Gabriele Kahlout commented on MNBMODULE-112:
--------------------------------------------

The diff is taken from the code I checked out, before patching the other issues 
I reported. So every patch includes all the issues, and not only the ones for 
this patch.

The only change made to master.jnlp here is:
+        <java version="1.6+" href="http://java.sun.com/products/autodl/j2se"; 
java-vm-args="${netbeans.run.params}"/>

To the CreateWebstartAppMojo.java:

if ( additionalArguments == null ){
+                additionalArguments = "";
+            }
+            final StringTokenizer st = new StringTokenizer(additionalArguments 
);
+            final StringBuilder stBuilder = new StringBuilder("");
+            while ( st.hasMoreTokens() ){
+                final String arg = st.nextToken();
+                if(arg.startsWith( "-J")){
+                    stBuilder.append( arg.substring( 2) ).append( " ");
+                }
+            }
+            
+            props.setProperty( "netbeans.run.params", stBuilder.toString());

and the additionalArguments instance variable:

     /**
      * If set true, build-jnlp target creates versioning info in jnlp 
descriptors and version.xml files.
      * This allows for incremental updates of Webstart applications, but 
requires download via
@@ -162,22 +153,32 @@
      * @parameter expression="${nbm.webstart.versions}" default-value="false"
      */
     private boolean processJarVersions;
+    /**
+     * additional command line arguments. Eg. 
+     * -J-Xdebug -J-Xnoagent 
-J-Xrunjdwp:transport=dt_socket,suspend=n,server=n,address=8888
+     * can be used to debug the IDE.
+     * @parameter expression="${netbeans.run.params}"
+     */
+    private String additionalArguments;


> Pass <additionalParameters> and  <target>1.6</target> for jnlp creation
> -----------------------------------------------------------------------
>
>                 Key: MNBMODULE-112
>                 URL: http://jira.codehaus.org/browse/MNBMODULE-112
>             Project: Maven NetBeans Module Plugin
>          Issue Type: Improvement
>            Reporter: Gabriele Kahlout
>            Assignee: Jesse Glick
>         Attachments: vmargs.diff
>
>
> These are there
> in the additionalArguments, but the MaveProject project reference didn't
> have it in the createwebstart phase (though it's there in the pom.xml).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to