[
http://jira.codehaus.org/browse/MNBMODULE-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=241908#action_241908
]
Gabriele Kahlout commented on MNBMODULE-113:
--------------------------------------------
>Do you have a clean patch for this against current trunk?
I've submitted a patch for MNBMODULE-115. Please review it, so that I submit
patch of this for the current trunk then.
>No reformatting of existing code
I think this is difficult to watch for (I often press the keyboard shortcut for
format to see things better). Also new code i right is in my default
formatting.
A better solution would be to enforce the formatting in your settings.xml
(and/or in the pom.xml). Does that sound good?
>no moving code into a new method like generateBrandingJnlp (unless necessary
>to avoid duplication)
I understand the coding style followed to reduce overhead and never anticipate.
I'll try to abide. You might still have to inline a few methods (in case you
disagree).You do that for generateExtensions(..) which is called once.
>Just to be sure I understand the problem being solved: the NB main frame
>>already shows the correct icon, yes?
So this only affects (1) the JNLP >splash screen briefly shown, (2) the icon
used for any JNLP desktop shortcut?
It depends on the jnlp client. According to the specification only jpeg and gif
are allowed. So the generated jnlp is non-compliant anyway.
I didn't investigate this but with this patch the icon remeains in the dock
(Mac) while in the previous one it'd not after restarting the app (but it might
be another issue).
This patch is constitent with the IDE branding interface.
See here: http://wiki.netbeans.org/DevFaqExecutableIcon
This affects both (1) and (2), and the dock (3) (and anywhere the icon is used
(can't refer to them w/o a long description).
The main issue though is that unless one specifies an absolute path (maybe
relative (../) would also work) the developer needs to place the icon image in
the webstart folder which is emptied at each build.
> Use branding icon and splash icons in jws
> -----------------------------------------
>
> Key: MNBMODULE-113
> URL: http://jira.codehaus.org/browse/MNBMODULE-113
> Project: Maven NetBeans Module Plugin
> Issue Type: Improvement
> Affects Versions: 3.4
> Reporter: Gabriele Kahlout
> Assignee: Jesse Glick
> Priority: Minor
> Attachments: brandingIcons.diff
>
>
> So far the icon used for a JWS nb app is master.jnlp expected in the target
> folder, which is cleaned.
> The branding icon and splash are not used.
> Attached path uses the splash, which is expected in branding resources as
> well as the icon image (frame32).
> Tested on two projects:
> 1. new maven project from dev ide.
> 2. memorizeasy.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
