[
http://jira.codehaus.org/browse/MNBMODULE-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=241998#action_241998
]
Gabriele Kahlout commented on MNBMODULE-113:
--------------------------------------------
The consistency argument is:
In the IDE you have a branding... window for setting the splash screen and 3
icons to be used by the application. However, as the link explains, these are
not used at all (except the splash screen in the standard build). So why do you
trick developers into thinking they are used? Especially since NB IDE indeed
comes with icons. The patch I proposed fixes that for maven + jws users by
actually retrieving these (gifs, because that's how branding expects them) from
where the branding module stores them, and fits them in the jnlp. Hence the
branding interface is consistent with the generated output (those icons are
finally used to the greatest extent supported by jws). Likewise icons are where
they ought to be, in the resources of branding.
The current patch is not that much out of the way. The code 'reshuffling' is
required since I re-used the code to retrieve these icons from the branding
resources folder.
My current version generates the jnlps dynamically and hence a patch would add
the icons to BuildJnlp.java and not to master.jnlp (and
createWebstartMojo.java). Hence, if we sort the href issue where that
refactoring is proposed it'll be less work for me to patch this one, consistent
with the latest trunk.
> Use branding icon and splash icons in jws
> -----------------------------------------
>
> Key: MNBMODULE-113
> URL: http://jira.codehaus.org/browse/MNBMODULE-113
> Project: Maven NetBeans Module Plugin
> Issue Type: Improvement
> Affects Versions: 3.4
> Reporter: Gabriele Kahlout
> Assignee: Jesse Glick
> Priority: Minor
> Attachments: brandingIcons.diff
>
>
> So far the icon used for a JWS nb app is master.jnlp expected in the target
> folder, which is cleaned.
> The branding icon and splash are not used.
> Attached path uses the splash, which is expected in branding resources as
> well as the icon image (frame32).
> Tested on two projects:
> 1. new maven project from dev ide.
> 2. memorizeasy.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
