[ 
http://jira.codehaus.org/browse/MNBMODULE-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=242026#action_242026
 ] 

Jesse Glick commented on MNBMODULE-113:
---------------------------------------

DevFaqExecutableIcon explains that these icons are used in the Java runtime for 
various window icons. But having them be used also for e.g. the application 
shortcut would be useful. It does indeed appear that {{<icon 
href="master.png"/>}} is generated by the Maven plugin without actually 
creating {{master.png}}, which must have been an oversight; in the Ant harness, 
currently {{master.png}} is copied if you define {{app.icon}}, but the branding 
GUI does not seem to do so, which should probably also be fixed. For now I will 
just delete the bogus icon declaration (revision 13025).

Branding support, and the IDE, should not care what format an icon is in. For 
historical reasons the branded filename must be e.g. {{frame.gif}}, so that it 
correctly overrides the original, but the file contents may in fact be a PNG; 
Java pays attention to the file header, not the extension.

Any stylistic refactorings should be filed as separate patches so as not to 
distract from bug fixes. The last patch I saw in this issue was mangled and 
incomplete.

> Use branding icon and splash icons in jws
> -----------------------------------------
>
>                 Key: MNBMODULE-113
>                 URL: http://jira.codehaus.org/browse/MNBMODULE-113
>             Project: Maven NetBeans Module Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.4
>            Reporter: Gabriele Kahlout
>            Assignee: Jesse Glick
>            Priority: Minor
>         Attachments: brandingIcons.diff
>
>
> So far the icon used for a JWS nb app is master.jnlp expected in the target 
> folder, which is cleaned.
> The branding icon and splash are not used.
> Attached path uses the splash, which is expected in branding resources as 
> well as the icon image (frame32). 
> Tested on two projects:
> 1. new maven project from dev ide.
> 2. memorizeasy.com

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to