[
https://jira.codehaus.org/browse/MOJO-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=277687#comment-277687
]
Christopher Hunt commented on MOJO-1732:
----------------------------------------
Thanks for the plugin. I would like to see the following added prior to
admitting to the sandbox:
* Unit tests (there are none) - also pay attention to Cobertura report
* Site documentation (there is none)
* Recommend the use of The Codehaus Bamboo infrastructure for CI
* Recommend depending on JUnit 4 (currently depends on JUnit 3)
* Issue tracking URL is incorrect for the sandbox; should be
http://jira.codehaus.org/browse/MOJO
* SCM URL needs to reflect the sandbox i.e.
scm:svn:http://svn.codehaus.org/mojo/trunk/sandbox/lesscss-maven-plugin
* Lots of check style warnings to be fixed - check out the check style report
* No Javadoc package documentation describing less css and the motivation for
the plugin
* Javadoc coverage generally lacking
* getLog().debug() calls should be surrounded with a getLog.isDebug() test
* Log info calls seem a little chatty; Maven already lets the user know what
plugin is executed
* Use File.separatorChar and File.separator in place of hardcoded "/" path
separators so that the plugin works on Windows.
On the plugin itself, just wondering if a better source folder would be:
{code}
${project.basedir}/src/main/lesscss
{code}
"webapp" implies a war file to me, which is not necessarily the target.
I've also found with my [JSLint Maven
Plugin|http://mojo.codehaus.org/jslint-maven-plugin/] is that it needs to be
discriminate about which files to compile. On larger projects I found that it
became increasingly slow to compile as the project I applied the plugin to
increased in the number of js files. You may find its logic for checking for
files to compile useful as these two plugins are similar in their behaviour.
> Create project for lesscss Mojo
> -------------------------------
>
> Key: MOJO-1732
> URL: https://jira.codehaus.org/browse/MOJO-1732
> Project: Mojo
> Issue Type: New Feature
> Components: _Plugin Submission
> Reporter: Marcel Overdijk
> Attachments: lesscss-maven-plugin.zip
>
>
> As discussed on the mailing list I'm working on a new Maven plugin for
> lesscss (www.lesscss.org).
> Less is the dynamic stylesheet language and the plugin will provide
> compilation of .less files to ordinary .css files, mainly during the compile
> or package (war) phase.
> Could you please create this project in the sandbox so I can work on this?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
