[
https://jira.codehaus.org/browse/MOJO-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Overdijk updated MOJO-1732:
----------------------------------
Attachment: lesscss-maven-plugin.zip
Hi Christopher,
Find attached an updated version.
1 general note about the plugin is that I included com.asual.lesscss sources
from other project. This project is working on getting this library being
published in Maven central. I just copied the Java sources without formatting
it or looking into unit tests. Before public release of lesscss plugin this
code should be removed and the library dependency added.
That being said, a lot of your points were related to these included sources
metioned above.
But I will update you with the changes bullet by bullet:
* Unit tests (there are none) - also pay attention to Cobertura report
** Added unit test for CompileMojo (as being mentioned above other classes will
be removed)
* Site documentation (there is none)
** Added site.xml, index.apt, usage.apt and faq.apt
* Recommend the use of The Codehaus Bamboo infrastructure for CI
** Added <ciManagement> with
<url>http://bamboo.ci.codehaus.org/browse/MOJO-LESSCSS</url> to the POM but I
don't know if this is enough...
* Recommend depending on JUnit 4 (currently depends on JUnit 3)
** JUnit 4 dependency was already included in POM
* Issue tracking URL is incorrect for the sandbox; should be
http://jira.codehaus.org/browse/MOJO
** Fixed
* SCM URL needs to reflect the sandbox i.e.
scm:svn:http://svn.codehaus.org/mojo/trunk/sandbox/lesscss-maven-plugin
** Fixed
* Lots of check style warnings to be fixed - check out the check style report
** For CompileMojo this looks fine imo
* No Javadoc package documentation describing less css and the motivation for
the plugin
** com.asual.lesscss sources will be removed so no issue I assume
* Javadoc coverage generally lacking
** Same as previous point
* getLog().debug() calls should be surrounded with a getLog.isDebug() test
** Fixed
* Log info calls seem a little chatty; Maven already lets the user know what
plugin is executed
** Removed
* Use File.separatorChar and File.separator in place of hardcoded "/" path
separators so that the plugin works on Windows.
** Used File(String, String) instead
I also used different sourceDirectory and outputDirectory default values as you
suggested.
Related to the filter logic I assume you mean checking on timestamps? At least
this is what I can see from JSLint Maven Plugin. The problem is that with LESS
you can also use imports so it might be difficult to implement this.
If you have any other comments or concerns let me know.
I hope with this version (and with above feedback) gives you a better feeling
for adding it to sandbox.
> Create project for lesscss Mojo
> -------------------------------
>
> Key: MOJO-1732
> URL: https://jira.codehaus.org/browse/MOJO-1732
> Project: Mojo
> Issue Type: New Feature
> Components: _Plugin Submission
> Reporter: Marcel Overdijk
> Attachments: lesscss-maven-plugin.zip, lesscss-maven-plugin.zip
>
>
> As discussed on the mailing list I'm working on a new Maven plugin for
> lesscss (www.lesscss.org).
> Less is the dynamic stylesheet language and the plugin will provide
> compilation of .less files to ordinary .css files, mainly during the compile
> or package (war) phase.
> Could you please create this project in the sandbox so I can work on this?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
