[
https://jira.codehaus.org/browse/MOJO-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ian Robertson updated MOJO-1772:
--------------------------------
Attachment: mojo-1772.patch
Attached is a patch to fix this. I chose to move a good deal of the processing
logic to a new class, ClassOccurrenceTracker. One reason was to make it easier
to do unit testing; another was to provide the freedom to add instance
variables without worrying about getting tripped up with the plexus injector.
mojo-1744 needs to have it's test case modified slightly. Since the test case I
have depends on the work I've done in MOJO-1767, I'll attach that change as a
separate patch.
> BanDuplicateClasses should only keep reference to non-ingored classes
> ---------------------------------------------------------------------
>
> Key: MOJO-1772
> URL: https://jira.codehaus.org/browse/MOJO-1772
> Project: Mojo
> Issue Type: Bug
> Components: extra-enforcer-rules
> Affects Versions: extra-enforcer-rules-1.0-alpha-2
> Reporter: Robert Scholte
> Attachments: mojo-1772.patch
>
>
> The current implementation is lazy, which might result in incorrect results.
> Unique classes are always added to {{classNames}}-List. If there's a second
> class with the same name, only the first class is checked if it should be
> ignored.
> So if the first one should not be ignored, but the second can, a false entry
> is added.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
