[
https://jira.codehaus.org/browse/MOJO-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=283047#comment-283047
]
Ian Robertson commented on MOJO-1772:
-------------------------------------
Why do you prefer to avoid helper classes? I'm sure you have a good reason; I'd
just like to understand :).
My main reason to factor out code into a helper class was because the code is
simplified by being able to track state in an object. While I couldn't find any
documentation of how m-e-p populates it's rule classes, the impression I got
was that any field could potentially be populated, meaning that tracking state
within a rule class would be problematic at best.
> BanDuplicateClasses should only keep reference to non-ingored classes
> ---------------------------------------------------------------------
>
> Key: MOJO-1772
> URL: https://jira.codehaus.org/browse/MOJO-1772
> Project: Mojo
> Issue Type: Bug
> Components: extra-enforcer-rules
> Affects Versions: extra-enforcer-rules-1.0-alpha-2
> Reporter: Robert Scholte
> Attachments: mojo-1772.1.patch, mojo-1772.it.patch, mojo-1772.patch
>
>
> The current implementation is lazy, which might result in incorrect results.
> Unique classes are always added to {{classNames}}-List. If there's a second
> class with the same name, only the first class is checked if it should be
> ignored.
> So if the first one should not be ignored, but the second can, a false entry
> is added.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
