[ 
https://jira.codehaus.org/browse/MOJO-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=283243#comment-283243
 ] 

Robert Scholte commented on MOJO-1772:
--------------------------------------

The {{org.apache.maven.plugins.enforcer}} should only contain rules and rule 
configuration objects. Be aware there are more rules in [this 
package|http://maven.apache.org/enforcer/enforcer-rules/xref/org/apache/maven/plugins/enforcer/package-frame.html],
 so you need to prevent class-collisions (one reason I made IgnorableDependency 
private).
The extra-enforcer-rules project will have more rules, so we need to keep this 
package clean.
Also, this is a convenience package, other classes should be placed under 
{{org.codehaus....}}


> BanDuplicateClasses should only keep reference to non-ingored classes
> ---------------------------------------------------------------------
>
>                 Key: MOJO-1772
>                 URL: https://jira.codehaus.org/browse/MOJO-1772
>             Project: Mojo
>          Issue Type: Bug
>          Components: extra-enforcer-rules
>    Affects Versions: extra-enforcer-rules-1.0-alpha-2
>            Reporter: Robert Scholte
>         Attachments: mojo-1772.1.patch, mojo-1772.it.patch, mojo-1772.patch
>
>
> The current implementation is lazy, which might result in incorrect results.
> Unique classes are always added to {{classNames}}-List. If there's a second 
> class with the same name, only the first class is checked if it should be 
> ignored.
> So if the first one should not be ignored, but the second can, a false entry 
> is added.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to