Re: [mojo-dev] consumer-maven-plugin added to sandbox

[Jörg Hohwiller]

Hi Robert,

I had a look at your changes.
Maybe this is the right way to go by using DefaultModelBuilder.
However your changes introduced various bugs:

This is wrong as it copies ALL profiles to the "flattened" POM.
> model.setProfiles( effectiveModel.getProfiles() );

> Activation activation = profile.getActivation();
> if ( !isConsumerRelevant( activation ) )
> {
>   activeProfiles.add( profile );
> }




How shall we proceed?

Regards
  Jörg

Am 03.03.2014 12:33, schrieb Jörg Hohwiller:

This is even more wrong as it may activate profiles where the activation evaluates to false. So far I only see that the new approach is making things a lot more complicated.

Hi Robert,



So I will dive further this week...

Best Regards
  Jörg

Am 01.03.2014 21:16, schrieb Robert Scholte:

thanks for all your hints and ideas. I very much appreciate your support :)

Hi Jörg,


Current code is still a bit dirty, but should show they way to go.

Robert

it seems like the DefaultProfileInjector is the class which blocks our solutions. After some digging I found that by tuning the ModelBuilder we get the resolution as done by Maven AND have to correct interpolation. Op Sat, 01 Mar 2014 00:02:27 +0100 schreef Robert Scholte <codeh...@sourcegrounds.com>:

smime.p7s
Description: S/MIME Cryptographic Signature