Hi Jörg,
ITs are fixed.
Although this approach may seem complicated, it will be as close as
possible to what Maven does. Complicated shouldn't be the issue, however
correctness does.
"However your changes introduced various bugs": the expected behavior
wasn't covered with a test, so IMO the term "bug" isn't correctly used.
Remember, we're still in this sandbox, i.e. work in progress. Instead say
"the plugin should also do .... when ..."
Based on the Stephens response, the generated pom still contains to much
info to be a pure consumer pom.
If you need one of the following attributes, we need to rename the plugin
asap:
- name
- description
- url
- inceptionyear
- scm
And there's another challenge: poms should also include the license as
comment. With both the ModelBuilder and MavenXpp3Writer this info is lost.
Robert
Op Wed, 05 Mar 2014 10:00:40 +0100 schreef Jörg Hohwiller
<jo...@j-hohwiller.de>:
Hi Robert,
I had a look at your changes.
Maybe this is the right way to go by using DefaultModelBuilder.
However your changes introduced various bugs:
This is wrong as it copies ALL profiles to the "flattened" POM.
> model.setProfiles( effectiveModel.getProfiles() );
> Activation activation = profile.getActivation();
> if ( !isConsumerRelevant( activation ) )
> {
> activeProfiles.add( profile );
> }
This is even more wrong as it may activate profiles where the activation
evaluates to false.
So far I only see that the new approach is making things a lot more
complicated.
How shall we proceed?
Regards
Jörg
Am 03.03.2014 12:33, schrieb Jörg Hohwiller:
Hi Robert,
thanks for all your hints and ideas. I very much appreciate your
support :)
So I will dive further this week...
Best Regards
Jörg
Am 01.03.2014 21:16, schrieb Robert Scholte:
Hi Jörg,
it seems like the DefaultProfileInjector is the class which blocks
our solutions.
After some digging I found that by tuning the ModelBuilder we get the
resolution as done by Maven AND have to correct interpolation.
Current code is still a bit dirty, but should show they way to go.
Robert
Op Sat, 01 Mar 2014 00:02:27 +0100 schreef Robert Scholte
<codeh...@sourcegrounds.com>:
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
