+1 (binding) 2018-01-31 9:18 GMT-08:00 sandeep krishnamurthy <[email protected] >:
> @Haibin: Thanks for leading this release and quickly fixing the source tar > issue. > > > +1 (binding) > > > > 1. Download source tar from release page - > https://github.com/apache/incubator-mxnet/releases/ > download/1.1.0.rc0/apache-mxnet-src-1.1.0.rc0-incubating.tar.gz > 2. Build from source on GPU machine (AWS instance p2.8x) with CUDA8. > 3. Run work in progress Keras2 with MXNet backend ( > https://github.com/deep-learning-tools/keras/tree/keras2_mxnet_backend) > test cases. All are successful and performance is as expected. > 1. Example use cases tested end to end - MNIST_MLP, CIFAR10_MLP, > MNIST_CNN, CIFAR10_CNN, CIFAR10_Resnet56. > > > Regards, > > Sandeep > > > On Tue, Jan 30, 2018 at 11:01 PM, Haibin Lin <[email protected]> > wrote: > > > @Sandeep, I've updated the release assets > > with apache-mxnet-src-1.1.0.rc0-incubating.tar.gz which contains > submodule > > source code. Please use the apache one to build. Thanks. > > > > Best, > > Haibin > > > > On Tue, Jan 30, 2018 at 8:47 PM, Chris Olivier <[email protected]> > > wrote: > > > > > I guess that was an oversight. rc2 has the full source. > > > I remember it generally has the source because there were complaints > that > > > there were licensing issues with the dmlc files. > > > > > > On Tue, Jan 30, 2018 at 8:38 PM, Haibin Lin <[email protected]> > > > wrote: > > > > > > > @Chris Are pre-releases expected to include submodules? I checked > > > 1.0.0.rc0 > > > > and 1.0.0.rc1, neither of them contain source code of submodules. > > > > > > > > On Tue, Jan 30, 2018 at 8:32 PM, Chris Olivier < > [email protected]> > > > > wrote: > > > > > > > > > All other relases have the submodule sources included > > > > > > > > > > On Tue, Jan 30, 2018 at 8:00 PM, sandeep krishnamurthy < > > > > > [email protected]> wrote: > > > > > > > > > > > I downloaded source from - > > > > > > https://github.com/apache/incubator-mxnet/archive/1.1.0. > rc0.tar.gz > > > and > > > > > > tried to build from source. > > > > > > Build failed as submodules (ps-list, mshadow) are empty directory > > in > > > > the > > > > > > source tar. > > > > > > > > > > > > Is this expected to not include submodules in source tar? > > > > > > > > > > > > > > > > > > On Tue, Jan 30, 2018 at 4:15 PM, Marco de Abreu < > > > > > > [email protected]> wrote: > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > On Tue, Jan 30, 2018 at 3:20 PM, Indhu < > [email protected]> > > > > > wrote: > > > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Jan 30, 2018 at 2:16 PM Chris Olivier < > > > > [email protected] > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > > > > > On Sun, Jan 28, 2018 at 12:35 AM, Haibin Lin < > > > > > > [email protected] > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Update: > > > > > > > > > > > > > > > > > > > > Link to release candidate 1.1.0.rc0: > > > > > > > > > > https://dist.apache.org/repos/ > dist/dev/incubator/mxnet/1.1 > > . > > > > > 0.rc0/ > > > > > > > > > > > > > > > > > > > > Link to the release tag: > > > > > > > > > > https://github.com/apache/incubator-mxnet/tree/1.1.0.rc0 > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > > Haibin > > > > > > > > > > > > > > > > > > > > On Sun, Jan 28, 2018 at 12:29 AM, Haibin Lin < > > > > > > > [email protected] > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > > > > > > > > > Given that most people on dev@ are in favor of a minor > > > > release > > > > > > > > (1.1.0) > > > > > > > > > > > instead of a patch release due to API changes, I'd like > > to > > > > > > propose > > > > > > > a > > > > > > > > > vote > > > > > > > > > > > to release Apache MXNet (incubating) 1.1.0. Voting will > > > start > > > > > now > > > > > > > > > > (Sunday, > > > > > > > > > > > January 28th) and end at 1pm Wednesday, January 31th > PST. > > > > > > > > > > > > > > > > > > > > > > Link to release notes: > > > > > > > > > > > https://cwiki.apache.org/confluence/display/MXNET/ > > > > > > > > > > > Apache+MXNet+%28incubating%29+1.1.0+Release+Notes > > > > > > > > > > > > > > > > > > > > > > Link to release candidate 1.1.0.rc0: > > > > > > > > > > > https://github.com/apache/ > incubator-mxnet/releases/tag/ > > > > > 1.1.0.rc0 > > > > > > > > > > > > > > > > > > > > > > View this page and scroll down to “Build from Source” > > with > > > > > source > > > > > > > > code > > > > > > > > > > > obtained from the 1.1.0.rc0 tag: > > > > > > > > > > > https://mxnet.incubator.apache.org/install/index.html > > > > > > > > > > > > > > > > > > > > > > (Note: The README.md points to the 1.1.0 tag and does > not > > > > work > > > > > at > > > > > > > the > > > > > > > > > > > moment.) > > > > > > > > > > > > > > > > > > > > > > Please remember to TEST first before voting > accordingly: > > > > > > > > > > > +1 = approve > > > > > > > > > > > +0 = no opinion > > > > > > > > > > > -1 = disapprove (provide reason) > > > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > > > Haibin > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Sandeep Krishnamurthy > > > > > > > > > > > > > > > > > > > > > > > > -- > Sandeep Krishnamurthy > > -- > Yizhi Liu > DMLC member > Amazon Web Services > Vancouver, Canada > >
